RE: [PATCH] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx
From: Jia Hongtao-B38951 <hidden>
Date: 2012-03-26 06:14:23
-----Original Message----- From: linuxppc-dev-bounces+b38951=3Dfreescale.com@lists.ozlabs.org [mailto:linuxppc-dev-bounces+b38951=3Dfreescale.com@lists.ozlabs.org] On Behalf Of Kumar Gala Sent: Saturday, March 17, 2012 5:04 AM To: <redacted> Cc: Zhao Chenhui-B35336; Liu Shuo-B35362; Zang Roy-R61911; Liu Shuo- B35362; Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] powerpc/85xx: Add machine check handler to fix PCIe erratum on mpc85xx =20 =20 On Feb 10, 2012, at 2:09 AM, [off-list ref] [off-list ref] wrote: =20quoted
From: Liu Shuo <redacted> A PCIe erratum of mpc85xx may causes a core hang when a link of PCIe goes down. when the link goes down, Non-posted transactions issued via the ATMU requiring completion result in an instruction stall. At the same time a machine-check exception is generated to the core to allow further processing by the handler. We implements the handler which skips the instruction caused the stall. Signed-off-by: Zhao Chenhui <redacted> Signed-off-by: Li Yang <redacted> Signed-off-by: Liu Shuo <redacted> --- arch/powerpc/kernel/cpu_setup_fsl_booke.S | 2 +- arch/powerpc/kernel/traps.c | 3 ++ arch/powerpc/sysdev/fsl_pci.c | 36+++++++++++++++++++++++++++++quoted
arch/powerpc/sysdev/fsl_pci.h | 6 +++++ 4 files changed, 46 insertions(+), 1 deletions(-)=20 Should we have a check to make sure the hose is for PCIe and not PCI? =20 - k
Due to errata spec pcie check is necessary. I will send a new version of this patch to solve this problem soon. Thanks. Btw, from now on I will follow this patch instead of Liu Shuo. - Jia Hongtao.