Re: [PATCH 4/4] powerpc/85xx: add the P1020UTM-PC DTS support

On Wed, Mar 14, 2012 at 09:30:27PM -0500, Huang Changming-R66093 wrote:

quoted

-----Original Message-----
From: Wood Scott-B07421
Sent: Thursday, March 15, 2012 2:50 AM
To: Huang Changming-R66093
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/4] powerpc/85xx: add the P1020UTM-PC DTS support

On 03/14/2012 04:08 AM, Chang-Ming.Huang@freescale.com wrote:

quoted

+&lbc {
+	nor@0,0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "cfi-flash";
+		reg = <0x0 0x0 0x2000000>;
+		bank-width = <2>;
+		device-width = <1>;
+
+		partition@0 {
+			/* 256KB for DTB Image */
+			reg = <0x0 0x00040000>;
+			label = "NOR (RO) DTB Image";
+			read-only;
+		};
+
+		partition@40000 {
+			/* 3.75 MB for Linux Kernel Image */
+			reg = <0x00040000 0x003c0000>;
+			label = "NOR (RO) Linux Kernel Image";
+			read-only;
+		};
+
+		partition@400000 {
+			/* 27MB for Root file System */
+			reg = <0x00400000 0x01b00000>;
+			label = "NOR (RW) Root File System";
+		};
+
+		partition@1f00000 {
+			/* This location must not be altered  */
+			/* 512KB for u-boot Bootloader Image */
+			/* 512KB for u-boot Environment Variables */
+			reg = <0x01f00000 0x00100000>;
+			label = "NOR (RO) U-Boot Image";
+			read-only;
+		};

Don't put (RW) or (RO) in the label; that information is already there in
the read-only property.

But for the user, after booting the kernel, he don't know these partition are read-only or can be wrote. 
If add (RW) or (RO), user can know which partition can be wrote or can't directly.

So fix the Linux MTD code to properly tell the user the read-only status
of any partition.

-Scott