Re: [PATCH 2/2] powerpc/44x: Add more changes for APM821XX EMAC driver

Thanks, David and Josh.

Except the coding style problem that David mentioned, do you have other
comment about my patch set?

Regards,
Duc Dang.

On Thu, Mar 1, 2012 at 1:25 AM, David Miller [off-list ref] wrote:

From: Josh Boyer <redacted>
Date: Wed, 29 Feb 2012 08:43:46 -0500

quoted

On Fri, Feb 17, 2012 at 3:07 AM, Duc Dang [off-list ref] wrote:

quoted

This patch includes:

 Configure EMAC PHY clock source (clock from PHY or internal clock).

 Do not advertise PHY half duplex capability as APM821XX EMAC does not
support half duplex mode.

 Add changes to support configuring jumbo frame for APM821XX EMAC.

Signed-off-by: Duc Dang <redacted>

This should have been sent to netdev.  CC'ing them now.

Ben and David, I can take this change through the 4xx tree if it looks

OK to

quoted

both of you.  The pre-requisite DTS patch will go through my tree, so it

might

quoted

make sense to keep them together.

Well the patch has coding style problems, for one:

quoted

quoted

+                    dev->features |=

(EMAC_APM821XX_REQ_JUMBO_FRAME_SIZE

quoted

quoted

+                                    | EMAC_FTR_APM821XX_NO_HALF_DUPLEX
+                                    | EMAC_FTR_460EX_PHY_CLK_FIX);

Should be:

quoted

quoted

+                    dev->features |=

(EMAC_APM821XX_REQ_JUMBO_FRAME_SIZE |

quoted

quoted

+                                      EMAC_FTR_APM821XX_NO_HALF_DUPLEX

|

quoted

quoted

+                                      EMAC_FTR_460EX_PHY_CLK_FIX);

And this:

quoted

quoted

+            dev->phy_feat_exc = (SUPPORTED_1000baseT_Half
+                                    | SUPPORTED_100baseT_Half
+                                    | SUPPORTED_10baseT_Half);

Should be:

quoted

quoted

+            dev->phy_feat_exc = (SUPPORTED_1000baseT_Half |
+                                 SUPPORTED_100baseT_Half |
+                                 SUPPORTED_10baseT_Half);