RE: [PATCH][v2] Device Tree Bindings for Freescale TDM controller

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Wednesday, March 21, 2012 11:37 PM
To: Aggrwal Poonam-B10812
Cc: devicetree-discuss@lists.ozlabs.org; linuxppc-dev@lists.ozlabs.org;
Singh Sandeep-B37400
Subject: Re: [PATCH][v2] Device Tree Bindings for Freescale TDM
controller
=20
=20
On Mar 19, 2012, at 8:02 PM, Poonam Aggrwal wrote:
=20

quoted

This TDM controller is available in various Freescale SOCs like
MPC8315, P1020, P1022, P1010.

Signed-off-by: Sandeep Singh <redacted>
Signed-off-by: Poonam Aggrwal <redacted>
---
Changes in v2:
	- Incorporated Scott's Review comments
Documentation/devicetree/bindings/tdm/fsl-tdm.txt |   67

+++++++++++++++++++++

quoted

1 files changed, 67 insertions(+), 0 deletions(-) create mode 100644
Documentation/devicetree/bindings/tdm/fsl-tdm.txt

diff --git a/Documentation/devicetree/bindings/tdm/fsl-tdm.txt

b/Documentation/devicetree/bindings/tdm/fsl-tdm.txt
new file mode 100644
index 0000000..6553dbe

--- /dev/null
+++ b/Documentation/devicetree/bindings/tdm/fsl-tdm.txt

@@ -0,0 +1,67 @@
+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

quoted

+TDM Device Tree Binding
+Copyright (C) 2012 Freescale Semiconductor Inc.
+
+NOTE: The bindings described in this document are preliminary and
+subject to change.
+
+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

quoted

+TDM (Time Division Multiplexing)
+
+DESCRIPTION
+
+The TDM is full duplex serial port designed to allow various devices
+including digital signal processors (DSPs) to communicate with a
+variety of serial devices including industry standard framers, codecs,

other DSPs and microprocessors.

quoted

+
+The below properties describe the device tree bindings for Freescale
+TDM controller.
+This TDM controller is available on various Freescale Processors like
+MPC8315, P1020, P1022 and P1010.
+
+PROPERTIES
+
+  - compatible
+      Usage: required
+      Value type: <string>
+      Definition: Should contain "fsl,mpc8315-tdm".
+	  So mpc8315 will have compatible =3D "fsl,mpc8315-tdm";
+	  p1010 will have compatible "fsl,p1010-tdm", "fsl,mpc8315-tdm";
+
+  - reg
+      Usage: required
+      Definition: There are two reg resources. First is for  TDM

registers and

quoted

+	  the second for TDM DMAC registers.
+
+  - clock-frequency
+      Usage: optional
+      Value type: <u32>
+      Definition: The frequency at which the TDM block is operating.
+
+  - interrupts
+      Usage: required
+      Definition: This field defines the interrupt specifiers for the

two

quoted

+      interrupts. First is for TDM error and second for TDM DMAC.
+
+  - phy-handle
+      Usage: optional
+      Value type: <phandle>
+      Definition: Phandle of the line controller node or framer node

eg. SLIC,

quoted

+	  E1/T1 etc.

=20
Which way are we going with the name of such handle properties?  Ie
should this be 'tdm-phy-handle' or keeping it generic is ok?
=20

tdm-phy-handle looks better, but generally all the devices mention just phy=
-handle (usb, tsec)=20

quoted

+
+  - fsl,max-time-slots
+      Usage: required
+      Value type: <u32>
+      Definition: Maximum number of 8-bit time slots in one TDM frame.
+	  This is the maximum number which TDM hardware supports.
+
+EXAMPLE
+
+	tdm@16000 {
+		compatible =3D "fsl,p1010-tdm", "fsl,mpc8315-tdm";
+		reg =3D <0x16000 0x200 0x2c000 0x2000>;
+		clock-frequency =3D <399999999>; /* typically filled by u-boot

*/

quoted

+		interrupts =3D <16 8 62 8>;
+		phy-handle =3D <&zarlink1>;
+		fsl-max-time-slots =3D <128>;
+	};
--
1.6.5.6


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

=20