Re: [PATCH 1/2] powerpc/44x: Fix PCI MSI support for Maui APM821xx SoC and Bluestone board
flat view
From: Wolfgang Denk <hidden>
Date: 2012-03-12 05:31:29
Also in:
lkml
Dear Mai La, In message [ref] you wrote:
This patch consists of: - Enable PCI MSI as default for Bluestone board - Change definition of number of MSI interrupt as it depends on SoC - Fix returning ENODEV as finding MSI node - Fix MSI physical high and low address - Keep MSI data logically Signed-off-by: Mai La <redacted>
This is an updated version of your patch of March 09, right - http://article.gmane.org/gmane.linux.kernel/1264255 ?? If so, you should mark ot as patch V2 in the Subject:, and add a description of what you changed.
quoted hunk ↗ jump to hunk
- SDR0_WRITE(sdr_addr, (u64)res.start >> 32); /*HIGH addr */ - SDR0_WRITE(sdr_addr + 1, res.start & 0xFFFFFFFF); /* Low addr */ - + mtdcri(SDR0, *sdr_addr, upper_32_bits(res.start)); /*HIGH addr */ + mtdcri(SDR0, *sdr_addr + 1, lower_32_bits(res.start)); /* Low addr */
...
+ msi->msi_addr_hi = (u32)(msi_phys >> 32); + msi->msi_addr_lo = (u32)(msi_phys & 0xffffffff);
Is there any reason for not using upper_32_bits() / lower_32_bits() consistently? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Real computer scientists despise the idea of actual hardware. Hard- ware has limitations, software doesn't. It's a real shame that Turing machines are so poor at I/O.