Re: [PATCH 1/2] powerpc/44x: Fix PCI MSI support for Maui APM821xx SoC and Bluestone board

On Thu, Mar 8, 2012 at 10:35 PM, Benjamin Herrenschmidt
[off-list ref] wrote:

On Fri, 2012-03-09 at 10:17 +0700, Mai La wrote:

quoted

This patch consists of:
- Enable PCI MSI as default for Bluestone board
- Define number of MSI interrupt for Maui APM821xx SoC using in Blueston=

e board

quoted

- Fix returning ENODEV as finding MSI node
- Fix MSI physical high and low address
- Keep MSI data logically

Signed-off-by: Mai La <redacted>
---

quoted

index 7b4df37..c86231e 100644

--- a/arch/powerpc/sysdev/Kconfig
+++ b/arch/powerpc/sysdev/Kconfig

@@ -20,6 +20,12 @@ config PPC_MSI_BITMAP

=A0 =A0 =A0 default y if FSL_PCI
=A0 =A0 =A0 default y if PPC4xx_MSI

+config PPC4xx_NR_MSI_IRQS
+ =A0 =A0 int "Number of PCI MSI interrupts"
+ =A0 =A0 depends on PCI_MSI && PPC4xx_MSI
+ =A0 =A0 default "4" if !APM821xx
+ =A0 =A0 default "8" if APM821xx
+

=A0.../...

quoted

+#define NR_MSI_IRQS CONFIG_PPC4xx_NR_MSI_IRQS

ARGH.

We asked to -NOT MAKE THIS A COMPILE TIME OPTION-

Actually, I asked for basically exactly above.  I was _wrong_ in asking,
but it was asked for.

CONFIG_foo is as bad as your previous ifdef, in fact you just added a
useless config option here.

Make that number dynamic. Count the entries in the device-tree (or add
a property with the number in it, whatever you fancy the most) but make
it something detected at RUNTIME !!!!!

My apologies Mai.  Ben is correct here and I should have thought more
about my suggestion before I made it.

josh