Thread (11 messages) 11 messages, 6 authors, 2012-02-20

Re: Build fail in hugetlbpage.c with linux-next and mpc85xx_defconfig

From: Stephen Rothwell <hidden>
Date: 2012-02-16 00:15:26
Also in: linux-next

Hi Rusty,

On Thu, 16 Feb 2012 10:08:41 +1100 Michael Neuling [off-list ref] wrote:
This has been broken in linux-next for a while.  Looks like a merge
issue but you were the last to touch it...

arch/powerpc/mm/hugetlbpage.c: In function 'reserve_hugetlb_gpages':
arch/powerpc/mm/hugetlbpage.c:313: error: passing argument 5 of 'parse_args' makes integer from pointer without a cast
include/linux/moduleparam.h:317: note: expected 's16' but argument is of type 'int (*)(char *, char *)'
arch/powerpc/mm/hugetlbpage.c:313: error: too few arguments to function 'parse_args'
This was broken by commit b8076966e8e1 ("params: <level>_initcall-like
kernel parameters") from the rr tree which changed the parse_args() API without fixing all
the callers ....

Please add a fix ...

Grep is your friend:

$ git grep -l '\<parse_args(' v3.3-rc1 
v3.3-rc1:Documentation/target/tcm_mod_builder.py
v3.3-rc1:arch/powerpc/mm/hugetlbpage.c
v3.3-rc1:arch/x86/tools/insn_sanity.c
v3.3-rc1:arch/x86/tools/test_get_len.c
v3.3-rc1:include/linux/moduleparam.h
v3.3-rc1:init/main.c
v3.3-rc1:kernel/module.c
v3.3-rc1:kernel/params.c

(The Documentation and x86 ones are a false positives, the powerpc one is real)
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Attachments

  • (unnamed) [application/pgp-signature] 836 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help