Re: [PATCH] drivers/video: compile fixes for fsl-diu-fb.c
flat view
From: Tabi Timur-B04825 <hidden>
Date: 2012-01-16 02:34:44
Also in:
linux-fbdev
Michael Neuling wrote:
In message[ref] you wrote:quoted
Michael Neuling wrote:quoted
Fix a bunch of compiler errors and warnings introduced in: commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0 Author: Timur Tabi[off-list ref] drivers/video: fsl-diu-fb: merge all allocated data into one block Signed-off-by: Michael Neuling<redacted> --- Timur: you do compile test your patches, right? :-PI have a script that tests each commit in a set to make sure it compiles=
,
quoted
so that git-bisect isn't broken.May I suggest you actually run the script next time :-P
Tomorrow, when I get into the office, I'll take a look. But my code has=20 always compiled. Can you give me the output of your compiler?
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c index acf292b..3006b2b 100644 --- a/drivers/video/fsl-diu-fb.c +++ b/drivers/video/fsl-diu-fb.c@@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *=
ofdev, pm_message_t state)
quoted hunk ↗ jump to hunk
struct fsl_diu_data *data; data =3D dev_get_drvdata(&ofdev->dev); - disable_lcdc(data->fsl_diu_info[0]); + disable_lcdc(&(data->fsl_diu_info[0])); return 0; }@@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *o=
fdev)
quoted hunk ↗ jump to hunk
struct fsl_diu_data *data; data =3D dev_get_drvdata(&ofdev->dev); - enable_lcdc(data->fsl_diu_info[0]); + enable_lcdc(&(data->fsl_diu_info[0]));
I prefer this: disable_lcdc(data->fsl_diu_info); Your change makes sense. I don't understand why it compiles on my system.= =20 Something strange is going on. --=20 Timur Tabi Linux kernel developer at Freescale=