Re: [PATCH 12/15] arch/powerpc/sysdev/fsl_pci.c: add missing iounmap

On Jan 12, 2012, at 3:55 AM, Julia Lawall wrote:

From: Julia Lawall <redacted>

Add missing iounmap in error handling code, in a case where the function
already preforms iounmap on some other execution path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
statement S,S1;
int ret;
@@
e = \(ioremap\|ioremap_nocache\)(...)
... when != iounmap(e)
if (<+...e...+>) S
... when any
   when != iounmap(e)
*if (...)
  { ... when != iounmap(e)
    return ...; }
... when any
iounmap(e);
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
arch/powerpc/sysdev/fsl_pci.c |    5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

applied to merge

- k