Re: [PATCH v2] powerpc/setup_{32, 64}.c: remove unneeded boot_cpuid{, _phys}
From: McClintock Matthew-B29882 <hidden>
Date: 2011-12-16 03:29:56
From: McClintock Matthew-B29882 <hidden>
Date: 2011-12-16 03:29:56
On Thu, Dec 15, 2011 at 9:12 PM, Benjamin Herrenschmidt [off-list ref] wrote:
On Mon, 2011-11-28 at 22:24 -0600, Matthew McClintock wrote:quoted
boot_cpuid and init_thread_info.cpu are redundant, just use the var that stays around longer and add a define to make boot_cpuid point at the correct value boot_cpudid_phys is not needed and can completly go away from the SMP case, we leave it there for the non-SMP case since the paca struct is not around to store this info This patch also has the effect of having the logical cpu number of the boot cpu be updated correctly independently of the ordering of the cpu nodes in the device tree.So what about head_fsl_booke.S comparing boot_cpuid to -1 ? That seems to be broken now in at least 2 ways, boot_cpuid doesn't exist anymore and you don't initialize it to -1 either...
This is 4/5 which is also waiting for your review. http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-October/093474.html -M=