Re: [PATCH 2/2 v2] mtd/nand: Add ONFI support for FSL NAND controller

On 12/06/2011 09:16 PM, Liu Shengzhou-B36685 wrote:

quoted

quoted

+			out_be32(&lbc->fbcr, 8);
+			elbc_fcm_ctrl->read_bytes = 8;
+		} else {
+			out_be32(&lbc->fbcr, 256);
+			elbc_fcm_ctrl->read_bytes = 256;
+		}

Any harm in always using 256?

-Scott

[Shengzhou] For NAND_CMD_READID command, the total bytes of entire ID string are 8, there are not 256 bytes so many, it's unnecessary and looks not so well logically to always using 256, though it works.

It's not performance critical, and always using 256 keeps things
simpler, and more robust if the length of the ID string grows in the
future (we used to assume it was 5 bytes...).

-Scott