Re: [PATCHv5] atomic: add *_dec_not_zero
From: Russell King - ARM Linux <hidden>
Date: 2011-12-04 21:33:16
Also in:
batman, linux-alpha, linux-arch, linux-arm-kernel, linux-mips, linux-um
On Sun, Dec 04, 2011 at 04:42:49PM +0100, Sven Eckelmann wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/alpha/include/asm/atomic.h b/arch/alpha/include/asm/atomic.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1LL, 0LL) diff --git a/arch/ia64/include/asm/atomic.h b/arch/ia64/include/asm/atomic.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) diff --git a/arch/mips/include/asm/atomic.h b/arch/mips/include/asm/atomic.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) diff --git a/arch/parisc/include/asm/atomic.h b/arch/parisc/include/asm/atomic.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) diff --git a/arch/powerpc/include/asm/atomic.h b/arch/powerpc/include/asm/atomic.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) diff --git a/arch/s390/include/asm/atomic.h b/arch/s390/include/asm/atomic.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) diff --git a/arch/sparc/include/asm/atomic_64.h b/arch/sparc/include/asm/atomic_64.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) diff --git a/arch/tile/include/asm/atomic_32.h b/arch/tile/include/asm/atomic_32.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1LL, 0LL) diff --git a/arch/tile/include/asm/atomic_64.h b/arch/tile/include/asm/atomic_64.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) diff --git a/arch/x86/include/asm/atomic64_64.h b/arch/x86/include/asm/atomic64_64.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) diff --git a/include/asm-generic/atomic64.h b/include/asm-generic/atomic64.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1LL, 0LL)
I think this is rather silly - all these definitions are very similar to each other. Is there really no way to put this into include/linux/atomic.h, maybe as something like: #ifndef atomic64_dec_not_zero #define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) #endif and avoid having to add essentially the same definition to 12 individual files? Architectures which want to override it can do by the following: #define atomic64_dec_not_zero atomic64_dec_not_zero which won't have any effect on C nor asm code.