RE: [PATCH] powerpc/p1023: set IRQ[4:6, 11] to high level sensitive for PCIe

-----Original Message-----
From: Wood Scott-B07421
Sent: Wednesday, November 16, 2011 6:14 AM
To: Kumar Gala
Cc: Zang Roy-R61911; linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/p1023: set IRQ[4:6, 11] to high level
sensitive for PCIe
=20
On 11/15/2011 03:51 PM, Kumar Gala wrote:

quoted

On Nov 7, 2011, at 2:32 AM, Roy Zang wrote:

Should be setting ALL PCIe interrupts to '2'?  As I think in general
we say these PCIe are 'active high'.  The only reason I would think
we would NOT do this is if they are shared with some external device
that is 'active low'.  If so we should comment that somewhere (maybe
in the .dts, maybe just in the commit message).

=20
I'd assume the ones that are pinned out are pulled high on the board.

yes. The boards pulled up the shared IRQs. PCIe specification does not spec=
ify 'active low' or 'active high', but for PCI, the INTx is 'active low'.

Active-low is normal, it's these non-pinned-out "external" interrupts
that are pulled low inside the SoC that are weird.

I agree here. Do you want me to add something to point out the "weird" in t=
he commit message?
Thanks.
Roy