Re: [PATCH] net: fsl_pq_mdio: fix non tbi phy access

Hi Andy,

On Tue, Nov 15, 2011 at 09:06:03AM -0600, Andy Fleming wrote:

On Nov 14, 2011, at 11:17 PM, Baruch Siach wrote:

quoted

On Mon, Nov 14, 2011 at 09:04:47PM +0000, Fleming Andy-AFLEMING wrote:

[snip]

quoted

quoted

And looking at the p1010si.dtsi, I see that it's automatically there for 
you.

How were you breaking?

Adding linuxppc to Cc.

My board is P1011 based, the single core version of P1020, not P1010. In 
p1020si.dtsi I see no tbi node. In p1020rdb.dts I see a tbi node but only for 
mdio@25000, not mdio@24000, which is what I'm using.

Am I missing something?

Well, that's a bug. In truth, the silicon dtsi trees should not have tbi 
nodes, as that's highly machine-specific. The p1020rdb is apparently relying 
on the old behavior, which is broken, and due to the fact that the first 
ethernet interface doesn't *use* the TBI PHY.

You should add this to your board tree:

                mdio@24000 {

                        tbi0: tbi-phy@11 {
                                reg = <0x11>;
                                device_type = "tbi-phy";
                        };
                };

And add the PHYs you use, as well as set reg (and the value after the "@") 
to something that makes sense for your board.

Thanks for your detailed explanation and prompt response. I've added a tbi 
node, dropped my patch, and now my board works as expected.

I am going to go right now, and add tbi nodes for all of the Freescale 
platforms. I will also modify the fsl_pq_mdio code to be more explicit about 
its reason for failure.

Please Cc me on these.

Thanks,
baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -