Re: [RFC][PATCH 08/30] powerpc/85xx: Rework P1020 SoC device tree
From: Kumar Gala <hidden>
Date: 2011-11-10 20:27:16
On Nov 10, 2011, at 12:58 PM, Scott Wood wrote:
On Thu, Nov 10, 2011 at 12:46:27PM -0600, Kumar Gala wrote:quoted
=20 On Nov 10, 2011, at 12:05 PM, Scott Wood wrote: =20quoted
On Thu, Nov 10, 2011 at 10:13:51AM -0600, Kumar Gala wrote:quoted
Split the P1020 SoC device tree into what we can include as a =
'prefix'
quoted
quoted
quoted
to the board device tree and what needs to be included as a =
'postfix'.
quoted
quoted
quoted
=20 This allows use more re-use and less duplication between various =
board
quoted
quoted
quoted
device tree configurations (32-bit address map vs 36-bit address =
map).
quoted
quoted
=20 Could you elaborate on the issues that require this pre/post =
approach?
quoted
=20 We utilize two 'features' of dtc to accomplish things. One is =
includes the other is 'merging of labeled nodes'.
quoted
=20 We can using merging to allow the board to specify the "reg" & =
"ranges"
quoted
values of a SoC node that might vary between physical address maps (32-bit vs 36-bit as example). =20 dtc is able to 'merge' multiple labeled nodes as well. So we use =
that
quoted
to handle board specific values for something like localbus if we =
want
quoted
to support both a 32-bit and 36-bit address map. =20quoted
What does the SoC part need to specify that has to override or go =
within
quoted
quoted
something the board specifies?=20 Not sure I follow the question.=20 My question is, why does the stuff in post need to be in post, versus =
pre?
=20 Why can't pre define the soc node, and let the board dts set ranges?=20=
Likewise for localbus, pci, etc. =20 -Scott
Gotcha, the reason we have -pre and -post is because of how dtc include = mechanism works. It builds it's tree in the order things are parsed in = the file. In addition, "labeled nodes" like we have in post for 'soc', = 'lbc', etc. have to be defined after they are referenced. - k=