Thread (3 messages) flat view 3 messages, 3 authors, 2011-11-20

Re: [PATCH] powerpc/p3060qds: Fix select of 'MPC8xxx_GPIO'

From: Kumar Gala <hidden>
Date: 2011-11-20 15:53:38
Also in: lkml

On Nov 12, 2011, at 5:50 PM, Paul Bolle wrote:
The driver for the Freescale P3060 QDS got added by commit 96cc017c5b
("[...] Add support for P3060QDS board"). Its Kconfig entry selects
MPC8xxx_GPIO. But at the time that driver got added MPC8xxx_GPIO was
already renamed to GPIO_MPC8XXX, by commit c68308dd50c ("gpio: move
mpc8xxx/512x gpio driver to drivers/gpio").

So make this driver select GPIO_MPC8XXX.

Signed-off-by: Paul Bolle <redacted>
---
0) Bravely untested: I haven't got the hardware nor the PPC toolchain
needed to build this. And it seems this needs (build) testing anyhow.

1) Sent to the people who wrote the two patches mentioned in the commit
explanation and CC'd the non-authors who signed-off these patches.

2) The config tools do not complain about selects that cannot be met
because they concern a Kconfig symbol that doesn't even exist. Shouldn't
they be made to complain in that case?

arch/powerpc/platforms/85xx/Kconfig |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
applied to merge

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help