Thread (17 messages) 17 messages, 6 authors, 2011-11-28

RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c

From: David Laight <hidden>
Date: 2011-11-15 14:52:56
Also in: lkml

=20
On Tue, 2011-11-15 at 11:26 +0000, Jenkins, Clive wrote:
quoted
quoted
fix whitespaces,tabs coding style issue and ...
=20
In my opinion this code was already correct, and would display
correctly
quoted
at any TAB setting. This patch changes it so that it displays
incorrectly at all TAB settings other than 8.
=20
Any tab setting other than 8 is incorrect and should not be used for
Linux code. If I view it in a proportionally-spaced font,=20
it's not going to line up right either. Fix your editor, if that's an
issue for you.

Personally I don't even attempt to line up argumants on
continuation lines - it just wastes vertical space.
I just indent them as any other continuation line, so
double-indent if using 4-char indents and 1/2 indent for
8-char indents.

Tabs have to be assumed to be 8 columns, otherwise all sorts
of tools just get it wrong.
(Or you ban tabs from source files.)

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help