Thread (27 messages) 27 messages, 5 authors, 2011-12-16

Re: [PATCH v3 1/3] virtio_console: Fix locking of vtermno.

From: Rusty Russell <hidden>
Date: 2011-11-11 04:28:21
Also in: lkml, xen-devel

On Tue, 08 Nov 2011 13:44:58 -0800, Miche Baker-Harvey [off-list ref] wrote:
Some modifications of vtermno were not done under the spinlock.

Moved assignment from vtermno and increment of vtermno together,
putting both under the spinlock.  Revert vtermno on failure.

Signed-off-by: Miche Baker-Harvey <redacted>
Does it matter?  It's normal not to lock in a function called
"init_XXX", since it's not exposed yet.

Or is it?

Thanks,
Rusty.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help