Thread (11 messages) 11 messages, 2 authors, 2011-11-24

Re: [1/4] powerpc: Revert show_regs() define for readability

From: Jimi Xenidis <hidden>
Date: 2011-10-28 19:40:46

On Oct 5, 2011, at 9:53 PM, Kumar Gala wrote:
quoted hunk ↗ jump to hunk
We had an existing ifdef for 4xx & BOOKE processors that got changed to
CONFIG_PPC_ADV_DEBUG_REGS.  The define has nothing to do with
CONFIG_PPC_ADV_DEBUG_REGS.  The define really should be:

#if defined(CONFIG_4xx) || defined(CONFIG_BOOKE)

and not

#ifdef CONFIG_PPC_ADV_DEBUG_REGS

Signed-off-by: Kumar Gala <redacted>

---
arch/powerpc/kernel/process.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 8f53954..a1b5981 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -657,7 +657,7 @@ void show_regs(struct pt_regs * regs)
	if ((regs->trap != 0xc00) && cpu_has_feature(CPU_FTR_CFAR))
		printk("CFAR: "REG"\n", regs->orig_gpr3);
	if (trap == 0x300 || trap == 0x600)
-#ifdef CONFIG_PPC_ADV_DEBUG_REGS
+#if defined(CONFIG_4xx) || defined(CONFIG_BOOKE)
		printk("DEAR: "REG", ESR: "REG"\n", regs->dar, regs->dsisr);
I'll be needing "|| defined(CONFIG_PPC_BOOK3E)" added to this please.
-jx

#else
		printk("DAR: "REG", DSISR: %08lx\n", regs->dar, regs->dsisr);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help