Re: [PATCH 2/3] [44x] Enable CONFIG_RELOCATABLE for PPC44x
From: Suzuki Poulose <hidden>
Date: 2011-10-27 08:43:34
On 10/27/11 00:46, Scott Wood wrote:
On 10/26/2011 02:12 PM, Suzuki Poulose wrote:quoted
On 10/25/11 21:04, Scott Wood wrote:quoted
On 10/12/2011 09:15 AM, Dave Hansen wrote:quoted
This is not the place to enforce that kind of thing. If CONFIG_RELOCATABLE is only supported on one platform, then do: config RELOCATABLE depends on 44x and take the 44x reference out of the #ifdef....but please first rename the existing, different CONFIG_RELOCATABLE behavior that is currently supported on e500.Scott, I have renamed the new type of relocation to RELOCATABLE_PPC32_PIE. The patches were posted yesterday. Please let me know your thoughts.I think it would make more sense to rename the existing behavior (maybe something like DYNAMIC_MEMSTART -- if there's even enough overhead to make it worth being configurable at all), since it's not fully relocatable and since 64-bit already uses RELOCATABLE to mean PIE.
I think leaving the current behaviour as it is, and adding the PIE as an additional configuration option would be safe and wouldn't disturb the existing dependencies. ( CRASH_DUMP etc. depend on RELOCATABLE for archs which work fine ). For architectures with smaller TLB sizes, can afford to do the page aligned old style mapping and not worry about PIE at all. Thats just my view. Disclaimer : I am not an expert in the BookE land. :-) Thanks Suzuki