Thread (32 messages) flat view 32 messages, 5 authors, 2011-10-10

RE: [PATCH] mlx4_en: fix transmit of packages when blue frame is enabled

From: David Laight <hidden>
Date: 2011-10-10 08:41:28
Also in: netdev

=20
What is this __iowrite64_copy... oh I see
=20
Nice, somebody _AGAIN_ added a bunch of "generic" IO=20
accessors that are utterly wrong on all archs except
x86 (ok, -almost-).
There isn't a single bloody memory barrier in there !
Actually memory barriers shouldn't really be added to
any of these 'accessor' functions.
(Or, at least, ones without barriers should be provided.)

The driver may want to to a series of writes, then a
single barrier, before a final write of a command (etc).

in_le32() from io.h is specially horrid!

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help