Re: [PATCH] asm-generic/gpio.h: merge basic gpiolib wrappers
From: Russell King - ARM Linux <hidden>
Date: 2011-10-27 13:53:53
Also in:
linux-alpha, linux-arch, linux-arm-kernel, linux-mips
On Thu, Oct 27, 2011 at 09:01:43AM -0400, Mike Frysinger wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h index 11ad0bf..741efb2 100644 --- a/arch/arm/include/asm/gpio.h +++ b/arch/arm/include/asm/gpio.h@@ -5,14 +5,15 @@ #include <mach/gpio.h> #ifndef __ARM_GPIOLIB_COMPLEX +/* assume the mach has defined this */ +#ifndef irq_to_gpio +#define irq_to_gpio irq_to_gpio +#endif
Oh, this isn't a valid assumption either - it's far from valid. Those sub-architectures which don't define __ARM_GPIOLIB_COMPLEX probably don't define any kind of irq_to_gpio function by any means. Some of our mach/gpio.h header files for sub-architectures using entirely gpiolib are entirely empty - and we want them to stay that way.