Re: [PATCH V2 1/2] gpio: move mpc8xxx/512x gpio driver to drivers/gpio
From: Grant Likely <hidden>
Date: 2011-09-21 16:33:09
On Wed, Sep 21, 2011 at 12:49:20PM +0200, Wolfram Sang wrote:
Move the driver to the place where it is expected to be nowadays. Also rename its CONFIG-name to match the rest and adapt the defconfigs. Finally, move selection of REQUIRE_GPIOLIB or WANTS_OPTIONAL_GPIOLIB to the platforms, because this option is per-platform and not per-driver. Signed-off-by: Wolfram Sang <redacted> Cc: Anatolij Gustschin <agust@denx.de> Cc: Grant Likely <redacted> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- I'd think this should go via ppc, so it is in sync with the defconfig update of patch 2/2. Changes since V1: Use -C in format-patch to show the rename.
Nit: I prefer to see the changelog before the s-o-b lines so that it gets included in the final commit text. Helps when trying to identify exactly which version of a patch got merged.
arch/powerpc/configs/85xx/p1023rds_defconfig | 2 +- arch/powerpc/configs/85xx/xes_mpc85xx_defconfig | 2 +- arch/powerpc/configs/mpc85xx_defconfig | 2 +- arch/powerpc/configs/mpc85xx_smp_defconfig | 2 +- arch/powerpc/configs/ppc6xx_defconfig | 2 +- arch/powerpc/platforms/512x/Kconfig | 1 + arch/powerpc/platforms/83xx/Kconfig | 9 ++++++--- arch/powerpc/platforms/85xx/Kconfig | 12 ++++++++---- arch/powerpc/platforms/86xx/Kconfig | 1 + arch/powerpc/platforms/Kconfig | 10 ---------- arch/powerpc/sysdev/Makefile | 1 - drivers/gpio/Kconfig | 8 ++++++++ drivers/gpio/Makefile | 1 + .../mpc8xxx_gpio.c => drivers/gpio/gpio-mpc8xxx.c | 0 14 files changed, 30 insertions(+), 23 deletions(-) rename arch/powerpc/sysdev/mpc8xxx_gpio.c => drivers/gpio/gpio-mpc8xxx.c (100%)
Looks good to me. Acked-by: Grant Likely [off-list ref] Yes, it probably should go via the ppc tree. I don't foresee any conflict issues with the gpio tree. g.