Re: [PATCH v11 4/5] powerpc: Add flexcan device support for p1010rdb.

On Aug 10, 2011, at 11:27 AM, Robin Holt wrote:

I added a simple clock source for the p1010rdb so the flexcan driver
could determine a clock frequency.  The p1010 flexcan device only has
an oscillator of system bus frequency divided by 2.
=20
Signed-off-by: Robin Holt <redacted>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>,
Acked-by: Wolfgang Grandegger <redacted>,
Cc: U Bhaskar-B22300 <redacted>
Cc: socketcan-core@lists.berlios.de,
Cc: netdev@vger.kernel.org,
Cc: PPC list <redacted>
Cc: Kumar Gala <redacted>
---
arch/powerpc/platforms/85xx/Kconfig    |    2 +
arch/powerpc/platforms/85xx/Makefile   |    2 +
arch/powerpc/platforms/85xx/clock.c    |   52 =

++++++++++++++++++++++++++++++++

arch/powerpc/platforms/85xx/p1010rdb.c |    8 +++++
4 files changed, 64 insertions(+), 0 deletions(-)
create mode 100644 arch/powerpc/platforms/85xx/clock.c

I dont understand how mpc85xx_clk_functions() ends up being associated =
with the frequency the flexcan is running at.

This either seems to global or I'm missing something.

I still think the clk / freq info should be in the device tree and =
handled in the driver and NOT arch/powerpc platform code.

- k=