Re: [PATCH 1/3] powerpc: numa: Remove double of_node_put in hot_add_node_scn_to_nid

Hi Stephen,

quoted

Index: linux-powerpc/arch/powerpc/mm/numa.c
===================================================================

--- linux-powerpc.orig/arch/powerpc/mm/numa.c	2011-06-06

08:07:35.148708089 +1000 +++
linux-powerpc/arch/powerpc/mm/numa.c	2011-08-10
11:31:59.723379868 +1000 @@ -1214,7 +1214,6 @@ int
hot_add_node_scn_to_nid(unsigned lon break; }
 
-		of_node_put(memory);
 		if (nid >= 0)
 			break;
 	}

Won't that need an of_node_put(memory) after the loop if (nid >=
0) ?  In fact you should be able to just move the of_node_put(memory)
to after the loop since of_node_put(NULL) is fine.

Nice catch! Will respin the patch.

Anton