Thread (70 messages) flat view 70 messages, 7 authors, 2011-08-31

Re: [Cbe-oss-dev] [PATCH 06/15] ps3flash: Fix region align checks

From: Andre Heider <hidden>
Date: 2011-08-01 20:56:31

On Mon, Aug 1, 2011 at 10:29 PM, Geert Uytterhoeven
[off-list ref] wrote:
On Mon, Aug 1, 2011 at 22:02, Andre Heider [off-list ref] wrote:
quoted
The region fields used by the align checks are set in
ps3stor_setup(), so move those after that call.
Are you sure?
Aren't they set in
arch/powerpc/platforms/ps3/device-init.c:ps3_setup_storage_dev()?
Hm right, unfortunate commit message... :)
dev->region_idx is set in ps3stor_probe_access(), which is called from
ps3stor_setup().
So the code always checked the first region, where it should check the
one beeing used.

Will fix the commit message.

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help