Re: [PATCH] powerpc/85xx: fix mpic configuration in CAMP mode
flat view
From: Scott Wood <hidden>
Date: 2011-07-11 19:39:19
Also in:
lkml
On Sun, 10 Jul 2011 20:55:32 +0200 Fabio Baltieri [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Change the string to check for CAMP mode boot on MPC85xx (eg. P2020) to match the one in the corresponding dts files (p2020rdb_camp_core{0,1}.dts). Without this fix the mpic is configured as in the SMP boot mode, which causes the first core to report a protected source interrupt error for devices of the other core and lock up. Signed-off-by: Fabio Baltieri <redacted> --- arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.cb/arch/powerpc/platforms/85xx/mpc85xx_rdb.c index 088f30b..a1e5e70 100644--- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c +++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c@@ -58,7 +58,7 @@ void __init mpc85xx_rdb_pic_init(void) return; } - if (of_flat_dt_is_compatible(root, "fsl,85XXRDB-CAMP")) { + if (of_flat_dt_is_compatible(root, "fsl,MPC85XXRDB-CAMP")) { mpic = mpic_alloc(np, r.start, MPIC_PRIMARY | MPIC_BIG_ENDIAN | MPIC_BROKEN_FRR_NIRQS,
Shouldn't we be setting MPIC_SINGLE_DEST_CPU in this case (as we do for the other case)? Or just drop this and specify pic-no-reset in the mpic node. -Scott