Re: [PATCH v3 1/3] driver core: Add ability for arch code to setup pdev_archdata

On Jul 1, 2011, at 5:09 PM, Greg KH wrote:

On Thu, Jun 23, 2011 at 06:33:57AM -0500, Kumar Gala wrote:

quoted

On some architectures we need to setup pdev_archdata before we add =

the

quoted

device.  Waiting til a bus_notifier is too late since we might need =

the

quoted

pdev_archdata in the bus notifier.  One example is setting up of =

dma_mask

quoted

pointers such that it can be used in a bus_notifier.
=20
We add noop version of arch_setup_pdev_archdata() in
<asm-generic/platform_device.h> and allow the arch code to override =

with

quoted

access the full definitions of struct device, struct platform_device, =

and

quoted

struct pdev_archdata.

=20
Isn't there some way to use "weak" symbols to keep us from having to
create this .h file in every single arch and then if the arch wants to
define it, it does so?
=20
That should make this patch simpler, right?
=20
thanks,
=20
greg k-h

Changing to weak should be doable if we are ok with the additional =
function call always happening.

- k