Re: [PATCH 4/6] hw_breakpoints: Breakpoints arch ability don't need perf events
From: K.Prasad <hidden>
Date: 2011-07-04 13:32:32
Also in:
lkml
On Tue, May 24, 2011 at 11:52:25PM +0200, Frederic Weisbecker wrote:
quoted hunk ↗ jump to hunk
The breakpoint support ability in an arch is not related to the fact perf events is built or not. HAVE_HW_BREAKPOINT only shows an ability so this dependency makes no sense anymore. Archs that select HAVE_HW_BREAKPOINT already ensure that perf event is built. Remove that dependency. Signed-off-by: Frederic Weisbecker <redacted> Cc: Ingo Molnar <redacted> Cc: Peter Zijlstra <redacted> Cc: Will Deacon <redacted> Cc: Prasad <redacted> Cc: Paul Mundt <redacted> --- arch/Kconfig | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)diff --git a/arch/Kconfig b/arch/Kconfig index f78c2be..ce4be89 100644 --- a/arch/Kconfig +++ b/arch/Kconfig@@ -149,7 +149,6 @@ config HAVE_DEFAULT_NO_SPIN_MUTEXES config HAVE_HW_BREAKPOINT bool - depends on PERF_EVENTS config HAVE_MIXED_BREAKPOINTS_REGS bool--
Just a thought you might want to consider... The need to keep the ability (HAVE_HW_BREAKPOINT) and the user-choice to enable hardware breakpoints (through HW_BREAKPOINT) in separate config options isn't very clear to me (and is a bit confusing with very similar names). Why not make HAVE_HW_BREAKPOINT selectable by the user (which in turn would turn on PERF_EVENTS) for a given architecture? Thanks, K.Prasad