Thread (14 messages) 14 messages, 4 authors, 2011-07-06

Re: [PATCH 2/2] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

From: Artem Bityutskiy <dedekind1@gmail.com>
Date: 2011-06-30 11:50:22

On Wed, 2011-06-29 at 11:43 -0500, Scott Wood wrote:
On Wed, 29 Jun 2011 09:22:04 +0300
Artem Bityutskiy [off-list ref] wrote:
quoted
On Tue, 2011-06-28 at 09:50 +0800, b35362@freescale.com wrote:
quoted
+	/* Hack for supporting the flash chip whose writesize is
+	 * larger than 2K bytes.
+	 */
Please, use proper kernel multi-line comments. Please, make sure
checkpatch.pl does not generate 13 errors with this patch.
Most of the checkpatch complaints are about existing style in the file --
particularly, the use of tabs only for indentation, with spaces used for
alignment beyond the indentation point.
OK, fair enough, but the multi-line comment is a valid complain,
although minor. And you guys could just fix the style issues as well in
a separate patch-set.

-- 
Best Regards,
Artem Bityutskiy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help