Re: powerpc/4xx: Regression failed on sil24 (and other) drivers

From
Ayman El-Khashab <hidden>
Date
2011-06-29 18:20:09
Reply to
Benjamin Herrenschmidt, 2011-06-29
On Wed, Jun 29, 2011 at 11:42:03AM +1000, Benjamin Herrenschmidt wrote:
On Mon, 2011-06-27 at 06:31 -0500, Ayman El-Khashab wrote:
quoted
On Mon, Jun 27, 2011 at 08:19:56PM +1000, Benjamin Herrenschmidt wrote:
quoted
On Sat, 2011-06-25 at 18:52 -0500, Ayman El-Khashab wrote:
quoted
I noticed during a recent development with the 460SX that a
simple device that once worked stopped.  I did a bisect to
find the offending commit and it turns out to be this one:

0e52247a2ed1f211f0c4f682dc999610a368903f is the first bad
commit
commit 0e52247a2ed1f211f0c4f682dc999610a368903f
Author: Cam Macdonell [off-list ref]
Date:   Tue Sep 7 17:25:20 2010 -0700

    PCI: fix pci_resource_alignment prototype
....
I suspect you don't have CONFIG_PCI_QUIRKS enabled... I think that's the
cause of your problem.

It looks like this config option controls both compiling the "generic"
quirks in from drivers/pci/quirk.c, and the actually mechanism for
having quirks in the first place (pci_fixup_device() goes away without
that config option).

I think we probably want to unconditionally select that if CONFIG_PCI is
enabled in arch/powerpc...

Can you try changing it and tell us if that helps ?
Yes, that fixed our problem, thanks for your time.  I am
going to try to get the MSI to work.

Ayman
Thread (6 messages) 6 messages, 2 authors, last reply 2011-06-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help