Thread (3 messages) flat view 3 messages, 3 authors, 2011-06-15

Re: [PATCH][v2] Add support for RTC device: pt7c4338 in rtc-ds1307.c

From: Timur Tabi <hidden>
Date: 2011-06-15 15:05:39

Priyanka Jain wrote:
 config RTC_DRV_DS1307
-	tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025"
+	tristate "Dallas/Maxim DS1307/37/38/39/40, ST M41T00, EPSON RX-8025, PT7C4338"
 	help
 	  If you say yes here you get support for various compatible RTC
 	  chips (often with battery backup) connected with I2C. This driver
 	  should handle DS1307, DS1337, DS1338, DS1339, DS1340, ST M41T00,
-	  EPSON RX-8025 and probably other chips. In some cases the RTC
-	  must already have been initialized (by manufacturing or a
+	  EPSON RX-8025, PT7C4338 and probably other chips. In some cases 
+	  the RTC  must already have been initialized (by manufacturing or a
 	  bootloader).
I think you should probably drop the Kconfig change, too.  It already says, "and
probably other chips", and you're also just bloating the summary line.  We can't
list every possible Dallas-compatible RTC chip here.

-- 
Timur Tabi
Linux kernel developer at Freescale
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help