On Wed, Jun 15, 2011 at 08:08:05AM -0700, H. Peter Anvin wrote:
On 06/15/2011 12:47 AM, Russell King - ARM Linux wrote:
quoted
quoted
OK, serial-8250 is clearly just plain wrong, since the 8250 series UARTs
are ubiquitous across just about every platform.
Floppy is special (in the short bus sense), since it is closely tied to
ISA DMA. Conditionalizing this on ISA DMA makes total sense.
No it doesn't. It depends on the ISA DMA API, not that the machine has
ISA DMA.
I have a platform which has no ISA DMA but uses the floppy driver. Please
don't break it.
OK, even more case in point, then.
It's already been solved - ARCH_MAY_HAVE_PC_FDC is supposed to be
defined to y in the cases where architectures have support for it.
What we do on ARM for example is:
config ARCH_MAY_HAVE_PC_FDC
bool
and then select that symbol for our platforms which can have the
floppy driver.
And in any case we already have definitions for the presence of the
ISA DMA API vs the common ISA DMA helpers in kernel/. The presence
of the ISA DMA API is given by CONFIG_ISA_DMA_API, while the
ISA DMA helper CONFIG_GENERIC_ISA_DMA.