Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB

3 messages, 3 authors, 2011-06-23 · open the first message on its own page

Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB

From: Kumar Gala <hidden>
Date: 2011-06-22 11:34:11 

On Jun 7, 2011, at 9:49 PM, Prabhakar Kushwaha wrote:

ten-bit interface (TBI) module is part of SoC not board.
=20
Move tbi entries from board related dts files to Si dts.
=20
Signed-off-by: Prabhakar Kushwaha <redacted>
---
Based upon =
http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch =
next)
quoted hunk
=20
arch/powerpc/boot/dts/p1020rdb.dts            |    9 ---------
arch/powerpc/boot/dts/p1020rdb_camp_core0.dts |    8 --------
arch/powerpc/boot/dts/p1020si.dtsi            |    6 +++++-
arch/powerpc/boot/dts/p2020rdb.dts            |    8 --------
arch/powerpc/boot/dts/p2020rdb_camp_core0.dts |    8 --------
arch/powerpc/boot/dts/p2020si.dtsi            |    6 +++++-
6 files changed, 10 insertions(+), 35 deletions(-)
=20
diff --git a/arch/powerpc/boot/dts/p1020rdb.dts =
b/arch/powerpc/boot/dts/p1020rdb.dts
quoted hunk
index d6a8ae4..a4e5d6c 100644
--- a/arch/powerpc/boot/dts/p1020rdb.dts
+++ b/arch/powerpc/boot/dts/p1020rdb.dts
@@ -211,14 +211,6 @@
			};
		};
=20
-		mdio@25000 {
-
-			tbi0: tbi-phy@11 {
-				reg =3D <0x11>;
-				device_type =3D "tbi-phy";
-			};
-		};
-
		enet0: ethernet@b0000 {
			fixed-link =3D <1 1 1000 0 0>;
			phy-connection-type =3D "rgmii-id";
@@ -227,7 +219,6 @@
=20
		enet1: ethernet@b1000 {
			phy-handle =3D <&phy0>;
-			tbi-handle =3D <&tbi0>;
			phy-connection-type =3D "sgmii";
=20
		};
I'm not sure we should do this.  The phy address we pick is board =
specific so it should NOT be in .dtsi

- k=

Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB

From: Grant Likely <hidden>
Date: 2011-06-22 16:34:34 

On Wed, Jun 22, 2011 at 5:34 AM, Kumar Gala [off-list ref] wro=
te:
On Jun 7, 2011, at 9:49 PM, Prabhakar Kushwaha wrote:
quoted
ten-bit interface (TBI) module is part of SoC not board.

Move tbi entries from board related dts files to Si dts.

Signed-off-by: Prabhakar Kushwaha <redacted>
---
Based upon http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.=
git (branch next)
quoted
arch/powerpc/boot/dts/p1020rdb.dts =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A09 ---=
------
quoted
arch/powerpc/boot/dts/p1020rdb_camp_core0.dts | =A0 =A08 --------
arch/powerpc/boot/dts/p1020si.dtsi =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A06 +++=
++-
quoted
arch/powerpc/boot/dts/p2020rdb.dts =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A08 ---=
-----
quoted
arch/powerpc/boot/dts/p2020rdb_camp_core0.dts | =A0 =A08 --------
arch/powerpc/boot/dts/p2020si.dtsi =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A06 +++=
++-
quoted
6 files changed, 10 insertions(+), 35 deletions(-)

diff --git a/arch/powerpc/boot/dts/p1020rdb.dts b/arch/powerpc/boot/dts/=
p1020rdb.dts
quoted
index d6a8ae4..a4e5d6c 100644
--- a/arch/powerpc/boot/dts/p1020rdb.dts
+++ b/arch/powerpc/boot/dts/p1020rdb.dts
@@ -211,14 +211,6 @@
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 };
=A0 =A0 =A0 =A0 =A0 =A0 =A0 };

- =A0 =A0 =A0 =A0 =A0 =A0 mdio@25000 {
-
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 tbi0: tbi-phy@11 {
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 reg =3D <0x11>=
;
quoted
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_type =
=3D "tbi-phy";
quoted
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 };
- =A0 =A0 =A0 =A0 =A0 =A0 };
-
=A0 =A0 =A0 =A0 =A0 =A0 =A0 enet0: ethernet@b0000 {
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 fixed-link =3D <1 1 1000 0 0=
;
quoted
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 phy-connection-type =3D "rgm=
ii-id";
quoted
@@ -227,7 +219,6 @@

=A0 =A0 =A0 =A0 =A0 =A0 =A0 enet1: ethernet@b1000 {
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 phy-handle =3D <&phy0>;
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 tbi-handle =3D <&tbi0>;
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 phy-connection-type =3D "sgm=
ii";
quoted
=A0 =A0 =A0 =A0 =A0 =A0 =A0 };
I'm not sure we should do this. =A0The phy address we pick is board speci=
fic so it should NOT be in .dtsi

Ah, okay.  I was under the impression that the tbi address was
internal to the SoC, and not configurable.

g.

RE: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB

From: Aggrwal Poonam-B10812 <hidden>
Date: 2011-06-23 07:24:06 

-----Original Message-----
From: linuxppc-dev-bounces+poonam.aggrwal=3Dfreescale.com@lists.ozlabs.or=
g
[mailto:linuxppc-dev-
bounces+poonam.aggrwal=3Dfreescale.com@lists.ozlabs.org] On Behalf Of Kum=
ar
Gala
Sent: Wednesday, June 22, 2011 5:04 PM
To: Kushwaha Prabhakar-B32579
Cc: meet2prabhu@gmail.com; devicetree-discuss@lists.ozlabs.org; linuxppc-
dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/85xx:DTS: Fix tbi node location for Px020RDB
=20
=20
On Jun 7, 2011, at 9:49 PM, Prabhakar Kushwaha wrote:
=20
quoted
ten-bit interface (TBI) module is part of SoC not board.

Move tbi entries from board related dts files to Si dts.

Signed-off-by: Prabhakar Kushwaha <redacted>
---
Based upon
http://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch
next)
quoted
arch/powerpc/boot/dts/p1020rdb.dts            |    9 ---------
arch/powerpc/boot/dts/p1020rdb_camp_core0.dts |    8 --------
arch/powerpc/boot/dts/p1020si.dtsi            |    6 +++++-
arch/powerpc/boot/dts/p2020rdb.dts            |    8 --------
arch/powerpc/boot/dts/p2020rdb_camp_core0.dts |    8 --------
arch/powerpc/boot/dts/p2020si.dtsi            |    6 +++++-
6 files changed, 10 insertions(+), 35 deletions(-)

diff --git a/arch/powerpc/boot/dts/p1020rdb.dts
b/arch/powerpc/boot/dts/p1020rdb.dts
quoted
index d6a8ae4..a4e5d6c 100644
--- a/arch/powerpc/boot/dts/p1020rdb.dts
+++ b/arch/powerpc/boot/dts/p1020rdb.dts
@@ -211,14 +211,6 @@
			};
		};

-		mdio@25000 {
-
-			tbi0: tbi-phy@11 {
-				reg =3D <0x11>;
-				device_type =3D "tbi-phy";
-			};
-		};
-
		enet0: ethernet@b0000 {
			fixed-link =3D <1 1 1000 0 0>;
			phy-connection-type =3D "rgmii-id";
@@ -227,7 +219,6 @@

		enet1: ethernet@b1000 {
			phy-handle =3D <&phy0>;
-			tbi-handle =3D <&tbi0>;
			phy-connection-type =3D "sgmii";

		};
=20
I'm not sure we should do this.  The phy address we pick is board
specific so it should NOT be in .dtsi
The TBI phy and it's address is internal to SOC.

Regards
Poonam
=20
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help