Re: [PATCH 3/5] drivers/amba: create devices from device tree

From
Grant Likely <hidden>
Date
2011-06-23 20:55:28
Also in
linux-arm-kernel, linux-devicetree, lkml
Reply to
Rob Herring, 2011-06-21
On Tue, Jun 21, 2011 at 2:07 PM, Rob Herring [off-list ref] wrote:
Grant,

On 06/21/2011 01:45 PM, Grant Likely wrote:
quoted
Add a function to create amba_devices (i.e. primecell peripherals)
from device tree nodes. The device tree scanning is done by the
of_platform_populate() function which can call of_amba_device_create
based on a match table entry.

Nodes with a "arm,primecell-periphid" property can override the h/w
peripheral id value.

Based on the original work by Jeremy Kerr.

Signed-off-by: Jeremy Kerr <redacted>
Acked-by: Linus Walleij <redacted>
Signed-off-by: Rob Herring <redacted>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
[grant.likely: add Jeremy's original s-o-b line, changes from review
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0comments, and moved all code to drivers/o=
f/platform.c]
quoted
Signed-off-by: Grant Likely <redacted>
---
=A0.../devicetree/bindings/arm/primecell.txt =A0 =A0 =A0 =A0 =A0| =A0 21=
 ++++++
quoted
=A0drivers/of/platform.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
 =A0 =A0 =A0| =A0 71 ++++++++++++++++++++
quoted
=A02 files changed, 92 insertions(+), 0 deletions(-)
=A0create mode 100644 Documentation/devicetree/bindings/arm/primecell.tx=
t
quoted
diff --git a/Documentation/devicetree/bindings/arm/primecell.txt b/Docum=
entation/devicetree/bindings/arm/primecell.txt
quoted
new file mode 100644
index 0000000..1d5d7a8
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/primecell.txt
@@ -0,0 +1,21 @@
+* ARM Primecell Peripherals
+
+ARM, Ltd. Primecell peripherals have a standard id register that can be=
 used to
quoted
+identify the peripheral type, vendor, and revision. This value can be u=
sed for
quoted
+driver matching.
+
+Required properties:
+
+- compatible : should be a specific value for peripheral and "arm,prime=
cell"
Can I review what I wrote... Perhaps we should put strings in for all
existing drivers in the kernel. This should be a complete list:

arm,pl010
arm,pl011
st,pl011
arm,pl022
st,pl022
st,pl023
arm,pl030
arm,pl031
st,pl031
arm,pl061
arm,pl050
arm,pl080
arm,pl081
st,pl080
arm,pl110
arm,pl180
arm,pl330
arm,sp804
arm,sp805

Yes, this whole list should be added.

g.
Thread (9 messages) 9 messages, 3 authors, 2012-03-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help