Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h
From: Richard Weinberger <richard@nod.at>
Date: 2011-06-02 22:34:53
Also in:
linux-mips, linux-s390, linux-sh, linux-um, lkml, sparclinux
Am Donnerstag 02 Juni 2011, 23:04:58 schrieb Eric Paris:
quoted hunk ↗ jump to hunk
b/arch/um/sys-i386/shared/sysdep/ptrace.h index d50e62e..ef5c310 100644--- a/arch/um/sys-i386/shared/sysdep/ptrace.h +++ b/arch/um/sys-i386/shared/sysdep/ptrace.h@@ -162,6 +162,7 @@ struct syscall_args { #define UPT_ORIG_SYSCALL(r) UPT_EAX(r) #define UPT_SYSCALL_NR(r) UPT_ORIG_EAX(r) #define UPT_SYSCALL_RET(r) UPT_EAX(r) +#define regs_return_value UPT_SYSCALL_RET
This does not work at all.
UPT_SYSCALL_RET expects something of type struct uml_pt_regs.
#define regs_return_value REGS_EAX
Would be correct. (For x86_64 it needs to be REGS_RAX)
But there seems to be another problem.
Why is pt_regs of type void *?
gcc complains:
In file included from include/linux/fsnotify.h:15:0,
from include/linux/security.h:26,
from init/main.c:32:
include/linux/audit.h: In function =E2=80=98audit_syscall_exit=E2=80=99:
include/linux/audit.h:440:17: warning: dereferencing =E2=80=98void *=E2=80=
=99 pointer
include/linux/audit.h:440:3: error: invalid use of void expression
include/linux/audit.h:441:21: warning: dereferencing =E2=80=98void *=E2=80=
=99 pointer
include/linux/audit.h:441:21: error: void value not ignored as it ought to =
be
Thanks,
//richard