Re: [PATCH V2 1/2] Maple: register CPC925 EDAC device on all boards with CPC925

From
Segher Boessenkool <hidden>
Date
2011-05-23 15:39:15
Reply to
Dmitry Eremin-Solenikov, 2011-05-22
Currently Maple setup code creates cpc925_edac device only on
Motorola ATCA-6101 blade. Make setup code check bridge revision
and enable EDAC on all U3H bridges.

Verified on Momentum MapleD (ppc970fx kit) board.

Signed-off-by: Dmitry Eremin-Solenikov <redacted>
Acked-by: Segher Boessenkool <redacted>

One tiny thing:
quoted hunk ↗ jump to hunk
+	if (rev >= 0x34 && rev <= 0x3f) { /* U3H */
+		printk(KERN_ERR "%s: Non-CPC925(U3H) bridge revision: %02x\n",
+			__func__, rev);
+		return -ENODEV;
+	}
That's not really an error, is it?


Segher
Thread (4 messages) 4 messages, 2 authors, last reply 2011-05-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help