Thread (2 messages) 2 messages, 2 authors, 2011-05-20

[PATCH] agp/uninorth: Fix lockups with radeon KMS and >1x.

flat view
STALE5645d

From: Michel Dänzer <hidden>
Date: 2011-05-19 14:08:54
Also in: dri-devel
Subsystem: agpgart driver, the rest · Maintainers: David Airlie, Linus Torvalds

From: Michel Dänzer <redacted>

This was based on a description by Ben Herrenschmidt:
I've removed that SBA reset from the normal TLB invalidation path and
left it only once after turning AGP on.
About six months ago, he said:
I did it a bit differently, but yeah, you get the idea. I'm doing a
patch series so don't bother pushing things too hard yet.
But I haven't seen anything from him about this since then, and people are
regularly hitting these lockups, so here we are...

Signed-off-by: Michel Dänzer <redacted>
---
 drivers/char/agp/uninorth-agp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
index 47c2218..55af723 100644
--- a/drivers/char/agp/uninorth-agp.c
+++ b/drivers/char/agp/uninorth-agp.c
@@ -80,7 +80,7 @@ static void uninorth_tlbflush(struct agp_memory *mem)
 			       ctrl | UNI_N_CFG_GART_INVAL);
 	pci_write_config_dword(agp_bridge->dev, UNI_N_CFG_GART_CTRL, ctrl);
 
-	if (uninorth_rev <= 0x30) {
+	if (!mem && uninorth_rev <= 0x30) {
 		pci_write_config_dword(agp_bridge->dev, UNI_N_CFG_GART_CTRL,
 				       ctrl | UNI_N_CFG_GART_2xRESET);
 		pci_write_config_dword(agp_bridge->dev, UNI_N_CFG_GART_CTRL,
-- 
1.7.5.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help