Alan Cox wrote:

quoted

quoted

quoted

quoted

The kfifo API is probably faster and cleaner. Much of tty still uses
CIRC_* because they predate the new APIs.

Ok, I'll change it.

I flag that one up as a general comment - don't feel you need to change
it if CIRC_* works in your case.

CIRC_* does work for me, so I'll keep it as-is.

quoted

quoted

quoted

quoted

I guess the only other thing to consider is whether you want to implement
a SYSRQ interface on your console ?

I don't think byte channels can support SYSRQ, but I'll look into it.

What some drivers do in this case is nominate some obscure ctrl sequence
to mean 'sysrq' unless doubled (eg ctrl-^ etc)

Ok, I can do that.

Depends if the functionality is useful in your environment or not

It is, but I'd like to add it later so that I can make the 2.6.40 window (if it
isn't already too late).


-- 
Timur Tabi
Linux kernel developer at Freescale