On Mon, Apr 18, 2011 at 08:56:03AM +0200, Arnd Bergmann wrote:

On Monday 18 April 2011, Richard Cochran wrote:

quoted

+
+       lo = __raw_readl(&regs->channel[ch].src_uuid_lo);
+       hi = __raw_readl(&regs->channel[ch].src_uuid_hi);
+

I guess you should use readl(), not __raw_readl() here. The __raw_* functions
are not meant for device drivers.

Krzysztof had a different opinion about this.

    https://lkml.org/lkml/2011/1/8/67

Anyway, it is his driver, and I just followed what he does elsewhere
in the driver. It make sense to me to keep the driver consistent.
Maybe we should make the change throughout?

Thanks,
Richard