Re: [PATCH 4/4] KVM: PPC: e500: SPE switch between guest and host

On Tue, 29 Mar 2011 11:47:51 +0200
Alexander Graf [off-list ref] wrote:

On 28.03.2011, at 21:25, Scott Wood wrote:

quoted

@@ -344,10 +345,19 @@ int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu,

		r = RESUME_GUEST;
		break;

-	case BOOKE_INTERRUPT_SPE_UNAVAIL:
-		kvmppc_booke_queue_irqprio(vcpu, BOOKE_IRQPRIO_SPE_UNAVAIL);
+#ifdef CONFIG_SPE
+	case BOOKE_INTERRUPT_SPE_UNAVAIL: {

This means that on non-SPE enabled host kernels you'll get a KVM fatal error when the guest triggers SPE_UNAVAIL, as the exit simply isn't handled and triggers:

        default:
                printk(KERN_EMERG "exit_nr %d\n", exit_nr);
                BUG();

Right, thanks for spotting -- will have it send an illegal instruction trap
to the guest in that case.

-Scott