Thread (2 messages) 2 messages, 1 author, 2011-03-09

[PATCH] powerpc/pseries: Disable VPNH feature

flat view
STALE5701d

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2011-03-09 23:00:33
Subsystem: linux for powerpc (32-bit and 64-bit), the rest · Maintainers: Madhavan Srinivasan, Linus Torvalds

This feature triggers nasty races in the scheduler between the
rebuilding of the topology and the load balancing code, causing
the machine to hang.

Disable it for now until the races are fixed.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

Jesse: I'm sending that to Linus now. We'll sort things out for the
next release.
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index fd48123..74f1baa 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -1516,6 +1516,7 @@ int start_topology_update(void)
 {
 	int rc = 0;
 
+#if 0 /* Disabled until races with load balancing are fixed */
 	if (firmware_has_feature(FW_FEATURE_VPHN) &&
 	    get_lppaca()->shared_proc) {
 		vphn_enabled = 1;
@@ -1524,6 +1525,7 @@ int start_topology_update(void)
 		set_topology_timer();
 		rc = 1;
 	}
+#endif
 
 	return rc;
 }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help