Thread (12 messages) 12 messages, 2 authors, 2011-03-02

Re: [PATCH 0/8] fsldma: lockup fixes

From: Ira W. Snyder <hidden>
Date: 2011-03-02 16:42:50

On Wed, Mar 02, 2011 at 07:49:57AM +0200, Felix Radensky wrote:
Hi Ira,

On 03/01/2011 09:52 PM, Ira W. Snyder wrote:
quoted
On Tue, Mar 01, 2011 at 08:55:15AM -0800, Ira W. Snyder wrote:

[ big snip ]


I'd still like the bisect if you have a chance. I've re-reviewed the
patch series, and found the places that change register writes to the
controller.

The patch below changes the register operations back to the original
order. It doesn't make any sense why this would be required, but it is
worth a quick try.

I've added an "XXX" mark where you can comment out a single line if this
patch fails. It is highly unlikely to make any difference, but I'm
really having a hard time understanding what is wrong.
This patch fixes the problem. See below
Excellent! I know what is happening now. The 85xx controller doesn't
clear the "channel start" bit at the end of a transfer. Sure enough,
buried near the end of the chapter, the datasheet implies this in a
table very far away from the register definitions. The 83xx datasheet
explicitly states that it clears this bit automatically.

I'll post an updated patch series later today. Thank you so much for
being patient and trying out all of these patches.

Ira
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help