On Tue, 15 Mar 2011 22:22:19 +0530, Mahesh J Salgaonkar wrote:

On Tue, Mar 15, 2011 at 03:52:38PM +0800, Américo Wang wrote:

quoted

On Tue, Mar 15, 2011 at 2:13 AM, Mahesh J Salgaonkar
[off-list ref] wrote:

quoted

During free we do free all of them including RMO region. But since
the rtas region is always on top of RMO, crashkernel memory overlaps
rtas region and we endup freeing that even, which is causing the
crash.

Okay, but with this patch applied, we will just ignore rtas region,
right?

Correct.

quoted

Thus, when I echo 0 to free all the 128M crashkernel memory, the final
result will be 32M left, which means crash_size will still show 32M.
This looks odd.

How about skipping the 32M as a whole? I mean once the region being
freed has overlap with this rtas region, skip the whole rtas region,
and let crash_size
show 0?

The existing code from crash_shrink_memory() function reduces the crash
size to 0 when echo'ed 0. I did test this patchset and verified that
/sys/kernel/kexec_crash_size show 0 value.

Oh, ok.

Acked-by: WANG Cong <redacted>

Thanks.