Thread (8 messages) 8 messages, 5 authors, 2011-01-28

RE: [PATCH v2] gianfar: Fall back to software tcp/udp checksum on oldercontrollers

From: David Laight <hidden>
Date: 2011-01-28 09:13:02
Also in: netdev

=20
+		if (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12)
+			     && ((unsigned long)fcb % 0x20) > 0x18)) {
You need to check the generated code, but I think you need:

    if (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12))
	     && unlikely(((unsigned long)fcb % 0x20) > 0x18))

ie unlikely() around both the primitive comparisons.

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help