Re: [PATCH] powerpc: Fix some 6xx/7xxx CPU setup functions
From: kevin diggs <hidden>
Date: 2011-01-21 18:15:42
On Fri, Jan 21, 2011 at 12:35 AM, Benjamin Herrenschmidt [off-list ref] wrote:
Some of those functions try to adjust the CPU features, for example to remove NAP support on some revisions. However, they seem to use r5 as an index into the CPU table entry, which might have been right a long time ago but no longer is. r4 is the right register to use.
Can you quantify 'a long time ago'? Is this compiler dependent?
This probably caused some off behaviours on some PowerMac variants using 750cx or 7455 processor revisions.
what about a 750gx?
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- Can somebody with one of these PowerMacs test this ? I only managed to find a 7448 which not directly affected...
I have a GigE (PowerMac 3,4?) with an upgrade card that has a pair of 7455s on it and an 8600 with a 750GX cpu card. I can probably test this on the GigE. It is running 2.6.36. Is that recent enough? The 8600 is not cooperating. The GigE is running 2.6.36 compiled with 4.3.5 built from sources. It seems to run fine. _______________________________________________
Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev