Thread (11 messages) 11 messages, 5 authors, 2011-01-19

Re: [PATCH #upstream-fixes] pata_mpc52xx: inherit from ata_bmdma_port_ops

From: Jeff Garzik <hidden>
Date: 2011-01-19 01:00:34
Also in: linux-ide

On 01/09/2011 05:48 PM, Tejun Heo wrote:
quoted hunk ↗ jump to hunk
pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which
triggers BUG_ON() when a DMA command is issued.  Fix it.

Signed-off-by: Tejun Heo<tj@kernel.org>
Reported-by: Roman Fietze<redacted>
Cc: Sergei Shtylyov<redacted>
Cc: stable@kernel.org
---
  drivers/ata/pata_mpc52xx.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
index 8cc536e..d7d8026 100644
--- a/drivers/ata/pata_mpc52xx.c
+++ b/drivers/ata/pata_mpc52xx.c
@@ -610,7 +610,7 @@ static struct scsi_host_template mpc52xx_ata_sht = {
  };

  static struct ata_port_operations mpc52xx_ata_port_ops = {
-	.inherits		=&ata_sff_port_ops,
+	.inherits		=&ata_bmdma_port_ops,
  	.sff_dev_select		= mpc52xx_ata_dev_select,
  	.set_piomode		= mpc52xx_ata_set_piomode,
applied
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help