Thread (15 messages) 15 messages, 6 authors, 2011-01-22

Re: mpc880 linux-2.6.32 slow running processes

flat view

From: Joakim Tjernlund <hidden>
Date: 2011-01-06 16:58:02

quoted
quoted
+  /* On 8xx, cache control instructions (particularly
+   * "dcbst" from flush=5Fdcache=5Ficache) fault as write
+   * operation if there is an unpopulated TLB entry
+   * for the address in question. To workaround that,
+   * we invalidate the TLB here, thus avoiding dcbst
+   * misbehaviour.
+   */
+  /* 8xx doesn't care about PID, size or ind args */
+  =5Ftlbil=5Fva(addr, 0, 0, 0);
  #endif /* CONFIG=5F8xx */
+
+  if (!pg)
+   return pte;
+
+  if (!PageReserved(pg)&&  !test=5Fbit(PG=5Farch=5F1,&pg->flags)) {
     flush=5Fdcache=5Ficache=5Fpage(pg);
     set=5Fbit(PG=5Farch=5F1,&pg->flags);
    }
Rex, do you recall under what specific circumstances the =5Ftlbil=5Fva is
needed?  Is it possible that it will be caused by a dcbst in other
contexts that are not dependent on the state of PG=5Farch=5F1?
The 8xx tlbil=5Fva should not be needed in recent 2.6 after I fixed the 8xx=
 TLB code
to workaround the dcbst bug there instead. See=20
http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3Dcomm=
itdiff;h=3D0a2ab51ffb8dfdf51402dcfb446629648c96bc78;hp=3D60e071fee994ff98c3=
7d03a4a7c5a3f8b1e3b8e5

Not sure what release it went into though.

 Jocke=
=
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help