Thread (56 messages) 56 messages, 8 authors, 2011-05-03

Re: [PATCH 2/4 v4] video, sm501: add edid and commandline support

From: Heiko Schocher <hidden>
Date: 2011-01-25 08:04:59
Also in: linux-devicetree, linux-fbdev, lkml

Hello Paul,

Paul Mundt wrote:
On Mon, Jan 24, 2011 at 10:57:27AM +0100, Heiko Schocher wrote:
quoted
@@ -1884,7 +1935,6 @@ static int __devinit sm501fb_probe(struct platform_device *pdev)
 
 	if (info->pdata == NULL) {
 		dev_info(dev, "using default configuration data\n");
-		info->pdata = &sm501fb_def_pdata;
 	}
 
 	/* probe for the presence of each panel */
I assume this is accidental? I don't see how you're compensating for this
in any of the other patches at least, as it's orthogonal from the default
mode settings.
Seems so, rework this too, thanks!

bye,
heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help