Thread (6 messages) 6 messages, 4 authors, 2010-11-24

Re: [PATCH v1] ppc44x:PHY fixup for USB on canyonlands board

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2010-11-23 21:10:51
Also in: lkml

quoted
+	setbits8(&bcsr[7], BCSR_USB_EN);
+	udelay(100000);
+
+	clrbits8(&bcsr[7], BCSR_USB_EN);
+	udelay(100000);
Thats a total bootup delay of 200ms. Is this really needed?
In addition, so large delays should use msleep() if possible (depends
how early we are here).

Cheers,
Ben,
And I suggest to add a few comments to the code explaining why exactly you are 
setting/clearing the bits in the BCSR and the GPIO registers.
Seconded,

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help